On Wed, Apr 18, 2018 at 6:53 PM, Michael Paquier <mich...@paquier.xyz> wrote: >> I'm curious about what we'll find by just by adding >> Assert(!AnyBufferLockHeldByMe()) to the top of >> heap_tuple_fetch_attr(). AssertNotInCriticalSection() certainly found >> several bugs when it was first added. > > Yep.
I wrote a simple prototype of this. No assertion failed during a "make installcheck". Assertions were added to heap_tuple_fetch_attr(), and a couple of other places. -- Peter Geoghegan