Hi hackers, Enums index a number of the GUC tables. This all relies on the elements being carefully arranged to be in the same order as those enums. There are comments to say what enum index belongs to each table element.
But why not use designated initializers to enforce what the comments are hoping for? ~~ PSA a patch for the same. Doing this also exposed a minor typo in the comments. "ERROR_HANDLING" -> "ERROR_HANDLING_OPTIONS" Furthermore, with this change, now the GUC table elements are able to be rearranged into any different order - eg alphabetical - if that would be useful (my patch does not do this). ~~ In passing, I also made a 0002 patch to remove some inconsistent whitespace noticed in those config tables. Thoughts? ------ Kind Regards, Peter Smith. Fujitsu Australia.
v1-0001-GUC-tables-used-designated-initializers.patch
Description: Binary data
v1-0002-GUC-tables-remove-unnecessary-whitespace.patch
Description: Binary data
