Regards, Zhang Mingli On Sep 28, 2022, 21:50 +0800, Melih Mutlu <m.melihmu...@gmail.com>, wrote: > Hi all, > > The patch needed a rebase due to recent changes on pg_buffercache. > You can find the updated version attached. > > Best, > Melih > > ``` + + if (buffers_used != 0) + usagecount_avg = usagecount_avg / buffers_used; + + memset(nulls, 0, sizeof(nulls)); + values[0] = Int32GetDatum(buffers_used); + values[1] = Int32GetDatum(buffers_unused); + values[2] = Int32GetDatum(buffers_dirty); + values[3] = Int32GetDatum(buffers_pinned); + + if (buffers_used != 0) + { + usagecount_avg = usagecount_avg / buffers_used; + values[4] = Float4GetDatum(usagecount_avg); + } + else + { + nulls[4] = true; + } ```
Why compute usagecount_avg twice?