On 2022-10-20 Th 14:47, Robert Haas wrote: > On Thu, Oct 20, 2022 at 1:28 PM Tom Lane <[email protected]> wrote: >> Robert Haas <[email protected]> writes: >>> Cool. Here's a patch. >> LGTM, except I'd be inclined to ensure that all the macros >> are function-style, ie >> >> +#define IS_DIR_SEP(ch) IS_NONWINDOWS_DIR_SEP(ch) >> >> not just >> >> +#define IS_DIR_SEP IS_NONWINDOWS_DIR_SEP >> >> I don't recall the exact rules, but I know that the second style >> can lead to expanding the macro in more cases, which we likely >> don't want. It also seems like better documentation to show >> the expected arguments. > OK, thanks. v2 attached. >
Looks good. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
