Hi, On 2022-11-07 12:52:25 -0500, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > In the attached patch I renamed --with-segsize= to --with-segsize-mb= / > > -Dsegsize= to -Dsegsize_mb=, to avoid somebody building with > > --with-segsize=2 > > or such suddenly ending up with an incompatible build. > > For the purpose of exercising these code paths with the standard > regression tests, even a megabyte seems large -- we don't create > very many test tables that are that big.
Good point. > How about instead allowing the segment size to be set in pages? In addition or instead of --with-segsize/-Dsegsize? Just offering the number of pages seems like a not great UI. I guess we could add support for units or such? But that seems messy as well. Greetings, Andres Freund
