On Mon, Nov 14, 2022 at 5:52 AM Simon Riggs <simon.ri...@enterprisedb.com> wrote: > The attached patch is a reduced version of the original. It covers only: > * deprecation of the promote_trigger_file - there are no tests that > use that, hence why there is no test coverage for the patch > * changing the sleep time of the startup process to 60s > * docs and comments
LPGTM. If we also fix the bogus SIGALRM wakeups[1], then finally a completely idle recovery process looks like: kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0) kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0) kevent(8,0x0,0,{ },1,{ 60.000000000 }) = 0 (0x0) Presumably it would have no timeout at all in the next release. [1] https://www.postgresql.org/message-id/calj2acuiyn+zmpguvmgeoy1u7ino2qsvqrnufk8swpvk3a8...@mail.gmail.com