On Fri, Nov 18, 2022 at 3:41 PM Drouvot, Bertrand <bertranddrouvot...@gmail.com> wrote: > > > However, I have a suggestion to simplify it > > further by getting rid of the local variable tabentry and just > > returning pgstat_fetch_stat_tabentry_ext(IsSharedRelation(relid), > > relid);. Furthermore, the pgstat_fetch_stat_tabentry() can just be a > > static inline function. > Good point. While at it, why not completely get rid of > pgstat_fetch_stat_tabentry_ext(), like in v2 the attached?
Hm. While it saves around 20 LOC, IsSharedRelation() is now spread across, but WFM. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
