On 2022-11-17 Th 17:11, Andrew Dunstan wrote: > On 2022-11-04 Fr 10:06, Jehan-Guillaume de Rorthais wrote: >> On Thu, 3 Nov 2022 13:11:18 -0500 >> Justin Pryzby <pry...@telsasoft.com> wrote: >> >>> On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote: >>>> Nice catch, but this looks like massive overkill. I think we can very >>>> simply fix the test in just a few lines of code, instead of a 190 line >>>> fix and a 130 line TAP test. >>>> >>>> It was never intended to be able to compare markers like rc1 vs rc2, and >>>> I don't see any need for it. If you can show me a sane use case I'll >>>> have another look, but right now it seems quite unnecessary. >>>> >>>> Here's my proposed fix. >>>> >>>> diff --git a/src/test/perl/PostgreSQL/Version.pm >>>> b/src/test/perl/PostgreSQL/Version.pm index 8f70491189..8d4dbbf694 100644 >>>> --- a/src/test/perl/PostgreSQL/Version.pm >>> Is this still an outstanding issue ? >> The issue still exists on current HEAD: >> >> $ perl -Isrc/test/perl/ -MPostgreSQL::Version -le \ >> 'print "bug" if PostgreSQL::Version->new("9.6") <= 9.0' >> bug >> >> Regards, >> > Oops. this slipped off mt radar. I'll apply a fix shortly, thanks for > the reminder. > >
Done. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com