On Mon, Nov 21, 2022 at 1:17 PM Andres Freund <[email protected]> wrote: > On November 21, 2022 9:37:34 AM PST, Robert Haas <[email protected]> > wrote: > >On Mon, Nov 21, 2022 at 12:30 PM Andres Freund <[email protected]> wrote: > >> This can't quite be right - isn't this only applying the limit if we found > >> a > >> visible tuple? > > > >It doesn't look that way to me, but perhaps I'm just too dense to see > >the problem? > > The earlier version didn't have the issue, but the latest seems to only limit > after a visible tuple has been found. Note the continue; when fetching a heap > tuple fails.
Oh, that line was removed in Simon's patch but not in Jakub's version, I guess. Jakub's version also leaves out the last_block = block line which seems pretty critical. -- Robert Haas EDB: http://www.enterprisedb.com
