On Fri, 25 Nov 2022 at 11:47, vignesh C <vignes...@gmail.com> wrote: > > On Sun, 20 Nov 2022 at 09:29, vignesh C <vignes...@gmail.com> wrote: > > > > On Fri, 11 Nov 2022 at 11:03, Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > On Fri, Nov 11, 2022 at 4:17 PM Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > > > On Fri, Nov 11, 2022 at 4:09 PM Peter Smith <smithpb2...@gmail.com> > > > > wrote: > > > > > > > > > > On Fri, Nov 11, 2022 at 3:47 PM Peter Smith <smithpb2...@gmail.com> > > > > > wrote: > > > > > > > > > > > > Here are more review comments for the v32-0001 file ddl_deparse.c > > > > > > > > > > > > *** NOTE - my review post became too big, so I split it into > > > > > > smaller parts. > > > > > > > > > > > > > > > THIS IS PART 4 OF 4. > > > > > > ======= > > > > > > src/backend/commands/ddl_deparse.c > > > > Thanks for the comments, the attached v39 patch has the changes for the > > same. > > One comment: > While fixing review comments, I found that default syntax is not > handled for create domain: > + /* > + * Verbose syntax > + * > + * CREATE DOMAIN %{identity}D AS %{type}T %{not_null}s %{constraints}s > + * %{collation}s > + */ > + createDomain = new_objtree("CREATE"); > + > + append_object_object(createDomain, > + "DOMAIN %{identity}D AS", > + > new_objtree_for_qualname_id(TypeRelationId, > + > objectId)); > + append_object_object(createDomain, > + "%{type}T", > + > new_objtree_for_type(typForm->typbasetype, typForm->typtypmod));
I have fixed this issue in the v40 patch attached at [1]. [1] - https://www.postgresql.org/message-id/CALDaNm1WEnw2Oykb90PO1c4oDAVrAR%2B16W8Cm_F-KzgNvqmmKg%40mail.gmail.com Regards, Vignesh