On Thu, Dec 1, 2022 at 6:42 AM David Rowley <dgrowle...@gmail.com> wrote: > > I was thinking that we should likely apply this before doing the hex > literals, which is the main focus of [1]. The reason being is so that > that patch can immediately have faster conversions by allowing the > compiler to use bit shifting instead of other means of multiplying by > a power-of-2 number. I'm hoping this removes a barrier for Peter from > the small gripe I raised on that thread about the patch having slower > than required hex, octal and binary string parsing.
I don't see why the non-decimal literal patch needs to be "immediately" faster? If doing this first leads to less code churn, that's another consideration, but you haven't made that argument. -- John Naylor EDB: http://www.enterprisedb.com
