Maciek Sakrejda <m.sakre...@gmail.com> writes: > While browsing through varsup.c, I noticed this comment on GetNewObjectId: > * Hence, this routine should generally not be used directly. The only direct > * callers should be GetNewOidWithIndex() and GetNewRelFileNumber() in > * catalog/catalog.c.
> But AddRoleMems in user.c appears to also call the function directly: > /* get an OID for the new row and insert it */ > objectId = GetNewObjectId(); Yeah, that looks like somebody didn't read the memo. Want to submit a patch? regards, tom lane