On Sun, Dec 11, 2022 at 6:25 PM Amit Langote <amitlangot...@gmail.com> wrote: > I've attached 0001 to remove those extraneous code blocks and add a > comment mentioning that userid need not be recomputed. > > While staring at the build_simple_rel() bit mentioned above, I > realized that this code fails to set userid correctly in the > inheritance parent rels that are child relations of subquery parent > relations, such as UNION ALL subqueries. In that case, instead of > copying the userid (= 0) of the parent rel, the child should look up > its own RTEPermissionInfo, which should be there, and use the > checkAsUser value from there. I've attached 0002 to fix this hole. I > am not sure whether there's a way to add a test case for this in the > core suite.
Ah, I realized we could just expand the test added by 553d2ec27 with a wrapper view (to test checkAsUser functionality) and a UNION ALL query over the view (to test this change). I've done that in the attached updated patch, in which I've also addressed Justin's comments. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com
v2-0001-Remove-some-dead-code-in-selfuncs.c.patch
Description: Binary data
v2-0002-Correctly-set-userid-of-subquery-rel-s-child-rels.patch
Description: Binary data
