Hi, On 2022-12-29 13:51:37 -0500, Tom Lane wrote: > We might find that some GCC-impostor compilers have trouble with it, > but if so we can adjust the #ifdef here.
Yea. I suspect it's widely enough used that any compiler claiming to be gcc compatible has it, but ... > Getting nitpicky, I suggest calling it "HAVE_PRAGMA_GCC_SYSTEM_HEADER" > to align better with what you actually have to write. Makes sense. > + * Newer versions the perl headers trigger a lot of warnings with our > compiler > > "Newer versions of ..." please. Otherwise LGTM. Oops. > > Should we backpatch this? Given the volume of warnings it's probably a good > > idea. But I'd let it step in HEAD for a few days of buildfarm coverage > > first. > > +1 to both points. Pushed to HEAD. Greetings, Andres Freund
