On Fri, 19 Aug 2022 at 21:18, <i.laza...@postgrespro.ru> wrote: > > Andrey Borodin wrote 2022-08-18 06:35: > > > > I like the idea of one knob instead of one per each SLRU. Maybe we > > even could deduce sane value from NBuffers? That would effectively > > lead to 0 knobs :) > > > > Your patch have a prefix "v22-0006", does it mean there are 5 previous > > steps of the patchset? > > > > Thank you! > > > > > > Best regards, Andrey Borodin. > > Not sure it's possible to deduce from NBuffers only. > slru_buffers_scale_shift looks like relief valve for systems with ultra > scaled NBuffers. > > Regarding v22-0006 I just tried to choose index unique for this thread > so now it's fixed to 0001 indexing.
The patch does not apply on top of HEAD as in [1], please post a rebased patch: === Applying patches on top of PostgreSQL commit ID 325bc54eed4ea0836a0bb715bb18342f0c1c668a === === applying patch ./v23-0001-bucketed-SLRUs-simplified.patch patching file src/include/miscadmin.h ... patching file src/backend/utils/misc/guc.c Hunk #1 FAILED at 32. Hunk #2 FAILED at 2375. 2 out of 2 hunks FAILED -- saving rejects to file src/backend/utils/misc/guc.c.rej [1] - http://cfbot.cputube.org/patch_41_2627.log Regards, Vignesh