Hi, Thanks for your review.
shiy.f...@fujitsu.com <shiy.f...@fujitsu.com>, 11 Oca 2023 Çar, 11:56 tarihinde şunu yazdı: > On Mon, Nov 14, 2022 8:08 PM Melih Mutlu <m.melihmu...@gmail.com> wrote: > 1. > +# Binary enabled subscription should fail > +$node_subscriber_binary->wait_for_log("ERROR: insufficient data left in > message"); > > Should it be changed to "ERROR: ( [A-Z0-9]+:)? ", like other subscription > tests. > Done. > 2. > +# Binary disabled subscription should succeed > +$node_publisher->wait_for_catchup('tap_sub'); > > If we want to wait for table synchronization to finish, should we call > wait_for_subscription_sync()? > Done. > 3. > I also think it might be better to support copy binary only for publishers > of > v16 or later. Do you plan to implement it in the patch? > Done. Thanks, -- Melih Mutlu Microsoft
v5-0001-Allow-logical-replication-to-copy-table-in-binary.patch
Description: Binary data