On Thu, Jan 12, 2023 at 6:23 AM Pavel Stehule <pavel.steh...@gmail.com> wrote:
> > > st 11. 1. 2023 v 22:11 odesÃlatel Tom Lane <t...@sss.pgh.pa.us> napsal: > >> Pavel Stehule <pavel.steh...@gmail.com> writes: >> > st 11. 1. 2023 v 19:31 odesÃlatel Magnus Hagander <mag...@hagander.net> >> > napsal: >> >> This is only about Internal and C, isn't it? Isn't the oid of these >> >> static, and identified by INTERNALlanguageId and ClanguageId >> respectively? >> >> So we could just have the query show the prosrc column if the language >> oid >> >> is one of those two, and otherwise show "Please use \sf to view the >> >> source"? >> >> > I think it can be acceptable - maybe we can rename the column "source >> code" >> > like "internal name" or some like that. >> >> Yeah, "source code" has always been kind of a misnomer for these >> languages. >> >> > again I don't think printing "Please use \sf to view the source"? " >> often >> > can be user friendly. \? is clear and \sf is easy to use >> >> We could shorten it to "See \sf" or something like that. But if we change >> the column header to "internal name" or the like, then the column just >> obviously doesn't apply for non-internal languages, so leaving it null >> should be fine. >> > > +1 > > Sure, that works for me as well. I agree the suggested text was way too long, I was more thinking of "something in this direction" rather than that exact text. But yes, with a change of names, we can leave it NULL as well. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
