On Tue, 3 Jan 2023 at 19:49, Drouvot, Bertrand <bertranddrouvot...@gmail.com> wrote: > > Hi, > > On 12/10/22 10:54 AM, Drouvot, Bertrand wrote: > > Hi, > > > > On 12/7/22 11:11 AM, Drouvot, Bertrand wrote: > >> Hi, > >> > >>> Hi, > >>> > >>> As [1] mentioned above has been committed (83a1a1b566), please find > >>> attached V5 related to this thread making use of the new macros (namely > >>> PG_STAT_GET_RELENTRY_INT64 and PG_STAT_GET_RELENTRY_TIMESTAMPTZ). > >>> > >>> I switched from using "CppConcat" to using "##", as it looks to me it's > >>> easier to read now that we are adding another concatenation to the game > >>> (due to the table/index split). > >>> > >>> The (Tab,tab) or (Ind,ind) passed as arguments to the macros look "weird" > >>> (I don't have a better idea yet): purpose is to follow the naming > >>> convention for PgStat_StatTabEntry/PgStat_StatIndEntry and > >>> pgstat_fetch_stat_tabentry/pgstat_fetch_stat_indentry, thoughts? > >>> > >>> Looking forward to your feedback, > >>> > >> > >> Attaching V6 (mandatory rebase due to 8018ffbf58). > >> > >> While at it, I got rid of the weirdness mentioned above by creating 2 sets > >> of macros (one for the tables and one for the indexes). > >> > >> Looking forward to your feedback, > >> > >> Regards, > >> > > > > Attaching V7, mandatory rebase due to 66dcb09246. > > > > Attaching V8, mandatory rebase due to c8e1ba736b.
The patch does not apply on top of HEAD as in [1], please post a rebased patch: === Applying patches on top of PostgreSQL commit ID d540a02a724b9643205abce8c5644a0f0908f6e3 === === applying patch ./v8-0001-split_tables_indexes_stats.patch .... patching file src/backend/utils/activity/pgstat_table.c (renamed from src/backend/utils/activity/pgstat_relation.c) Hunk #25 FAILED at 759. .... 1 out of 29 hunks FAILED -- saving rejects to file src/backend/utils/activity/pgstat_table.c.rej [1] - http://cfbot.cputube.org/patch_41_3984.log Regards, Vignesh
