On Thu, Jan 19, 2023 at 12:06 PM Takamichi Osumi (Fujitsu) <osumi.takami...@fujitsu.com> wrote: > > Kindly have a look at the updated patch v17. >
Can we try to optimize the test time for this test? On my machine, it is the second highest time-consuming test in src/test/subscription. It seems you are waiting twice for apply_delay and both are for streaming cases by varying the number of changes. I think it should be just once and that too for the non-streaming case. I think it would be good to test streaming code path interaction but not sure if it is important enough to have two test cases for apply_delay. One minor comment that I observed while going through the patch. + /* + * The combination of parallel streaming mode and min_apply_delay is not + * allowed. + */ + if (IsSet(supported_opts, SUBOPT_MIN_APPLY_DELAY) && + opts->min_apply_delay > 0) I think it would be good if you can specify the reason for not allowing this combination in the comments. -- With Regards, Amit Kapila.
