On Monday, January 30, 2023 10:20 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > I have one comment on v89 patch: > > + /* > + * Using 'immediate' mode returns false to cause a switch to > + * PARTIAL_SERIALIZE mode so that the remaining changes will > be serialized. > + */ > + if (logical_replication_mode == LOGICAL_REP_MODE_IMMEDIATE) > + return false; > + > > Probably we might want to add unlikely() here since we could pass through this > path very frequently?
I think your comment makes sense, thanks. I updated the patch for the same. Best Regards, Hou zj
v90-0001-Extend-the-logical_replication_mode-to-test-the-.patch
Description: v90-0001-Extend-the-logical_replication_mode-to-test-the-.patch
