Hi, On 2023-02-03 20:18:48 -0800, Noah Misch wrote: > On Fri, Feb 03, 2023 at 12:52:50PM -0500, Tom Lane wrote: > > Andrew Dunstan <and...@dunslane.net> writes: > > > On 2023-01-22 Su 17:47, Tom Lane wrote: > > >> Yeah. That's one of my biggest gripes about pgperltidy: if you insert > > >> another assignment in a series of assignments, it is very likely to > > >> reformat all the adjacent assignments because it thinks it's cool to > > >> make all the equal signs line up. That's just awful. > > > > > Modern versions of perltidy give you much more control over this, so > > > maybe we need to investigate the possibility of updating. > > > > I have no objection to updating perltidy from time to time. I think the > > idea is just to make sure that we have an agreed-on version for everyone > > to use. > > Agreed. If we're changing the indentation of assignments, that's a > considerable diff already. It would be a good time to absorb other diffs > we'll want eventually, including diffs from a perltidy version upgrade.
ISTM that we're closer to being able to enforce pgindent than perltidy. At the same time, I think the issue of C code in HEAD not being indented is more pressing - IME it's much more common to have to touch a lot of C code than to have to touch a lot fo perl files. So perhaps we should just start with being more stringent with C code, and once we made perltidy less noisy, add that? Greetings, Andres Freund
