Re: [PATCH] Add pretty-printed XML output option

[Jim Jones]

On 09.02.23 00:09, Peter Smith wrote:

I noticed the xmlFreeDoc(doc) within the PG_CATCH is guarded but the
other xmlFreeDoc(doc) is not. As the doc is assigned outside the
PG_TRY shouldn't those both be the same?

Hi Peter,



Thanks a lot for the review!

Best, Jim

My logic there was the following: if program reached that part of the code it means that the xml_parse() and xmlDocDumpFormatMemory() worked, which consequently means that the variables doc and xmlbuf are != NULL, therefore not needing to be checked. Am I missing something?

smime.p7s
Description: S/MIME Cryptographic Signature