On Thu, Feb 9, 2023 at 12:56 PM Andres Freund <and...@anarazel.de> wrote: > > * Isn't it confusing that we have a suite by that name, given that we > > also need to use the unrelated --setup flag for some nearby testing > > recipes? > > Hm. I don't find it particularly confusing, but I don't think I'm a good judge > of that, too close.
> It'll work, but only if you have run setup before. And it'll not use changed C > code. I see. It's not that confusing on its own, but it does cause confusion once you consider how things fit together. Suppose I want to do the equivalent of running the amcheck tests -- the tests that run when "make check" runs from contrib/amcheck with an autoconf build. That looks like this with our current meson workflow: meson test -v --suite setup --suite amcheck Now consider what I have to run to get the equivalent of a "make installcheck" run from the contrib/amcheck directory: meson test -v --setup running --suite amcheck-running Notice that I have to specify "--suite setup" in the first example, whereas I have to specify "--setup running" in the second example instead -- at the same point in. Also notice the rest of the details almost match. This makes it quite natural to wonder if "--suite setup" is related to "--setup running" in some way, which is not the case at all. They're two wholly unrelated concepts. Why not change the suite name to tmp_install? That immediately reminds me of what's really going on here, since I'm used to seeing that directory name. And it clashes with "--suite setup" in a way that seems useful. -- Peter Geoghegan
