On Thu, Feb 16, 2023 at 12:49 AM Jim Jones <[email protected]> wrote: > > Accidentally left the VERBOSE settings out -- sorry! > > Now it matches the approach used in a xpath test in xml.sql, xml.out, > xml_1.out and xml_2.out > > -- Since different libxml versions emit slightly different > -- error messages, we suppress the DETAIL in this test. > \set VERBOSITY terse > SELECT xpath('/*', '<invalidns xmlns=''<''/>'); > ERROR: could not parse XML document > \set VERBOSITY default > > v11 now correctly sets xml_2.out. > > Best, Jim
Firstly, Sorry it seems like I made a mistake and was premature
calling bingo above for v9.
- today I repeated v9 'make check' and found it failing still.
- the new xmlformat tests are OK, but some pre-existing xmlparse tests
are broken.
- see attached file pretty-v9-results
----
OTOH, the absence of xml_2.out from this patch appears to be the
correct explanation for why my results have been differing.
----
Today I fetched and tried the latest v11.
It is failing too, but only just.
- see attached file pretty-v11-results
It looks only due to a whitespace EOF issue in the xml_2.out
@@ -1679,4 +1679,4 @@
-- XML format: empty string
SELECT xmlformat('');
ERROR: invalid XML document
-\set VERBOSITY default
\ No newline at end of file
+\set VERBOSITY default
------
The attached patch update (v12-0002) fixes the xml_2.out for me.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
v12-0001-Add-pretty-printed-XML-output-option.patch
Description: Binary data
v12-0002-PS-fix-EOF-for-xml_2.out.patch
Description: Binary data
pretty-v9-results
Description: Binary data
pretty-v11-results
Description: Binary data
