On 2023-Feb-20, Amit Langote wrote: > On Fri, Feb 17, 2023 at 9:02 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote:
> > I tried a few things for a new test case, but I was unable to find > > anything useful. Maybe an intermediate view, I thought; no dice. > > Maybe one with a security barrier would do? Anyway, for now I just kept > > what you added in v2. > > Hmm, I'm fine with leaving the test case out if it doesn't really test > the code we're changing, as you also pointed out? Yeah, pushed like that. > One more thing we could try is come up with a postgres_fdw test case, > because it uses the RelOptInfo.userid value for remote-costs-based > path size estimation. But adding a test case to contrib module's > suite test a core planner change might seem strange, ;-). Maybe. Perhaps adding it in a separate file there is okay? -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Small aircraft do not crash frequently ... usually only once!" (ponder, http://thedailywtf.com/)