On Sat, Feb 11, 2023 at 10:24:37AM -0800, Andres Freund wrote: > On 2023-02-08 21:03:19 -0800, Andres Freund wrote: > > Pushed the first (and biggest) commit. More tomorrow. > > Just pushed the actual pg_stat_io view, the splitting of the tablespace test, > and the pg_stat_io tests.
pg_stat_io says: * Some BackendTypes do not currently perform any IO in certain * IOContexts, and, while it may not be inherently incorrect for them to * do so, excluding those rows from the view makes the view easier to use. if (bktype == B_AUTOVAC_LAUNCHER && io_context == IOCONTEXT_VACUUM) return false; if ((bktype == B_AUTOVAC_WORKER || bktype == B_AUTOVAC_LAUNCHER) && io_context == IOCONTEXT_BULKWRITE) return false; What about these combinations? Aren't these also "can't happen" ? relation | bulkread | autovacuum worker relation | bulkread | autovacuum launcher relation | vacuum | startup -- Justin