Re: PG_FREE_IF_COPY extraneous in numeric_cmp?

[CK Tan]

Thanks!

On Fri, Feb 24, 2023 at 2:16 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
>
> CK Tan <ck...@vitessedata.com> writes:
> > Isn't it true that pfree() will never be called by PG_FREE_IF_COPY?
>
> No.  You're forgetting the possibility that PG_GETARG_NUMERIC will
> have to de-toast a toasted input.  Granted, numerics are seldom
> going to be long enough to get compressed or pushed out-of-line;
> but that's possible, and what's very possible is that they'll have
> a short header.
>
>                         regards, tom lane