Dagfinn Ilmari Mannsåker <ilm...@ilmari.org> writes: > Justin Pryzby <pry...@telsasoft.com> writes: > >> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: >>> > Is there any consideration of promoting these or other warnings to >>> > fatal? >>> >>> You mean the perl warnings? >> >> Yes - it'd be nice if the warnings caused an obvious failure to allow >> addressing the issue. I noticed the icu warning while looking at a bug >> in 0da243fed, and updating to add ZSTD. > > Perl warnings can be made fatal with `use warnings FATAL => > <categories>;`, but one should be careful about which categories to > fatalise, per <https://metacpan.org/pod/warnings#Fatal-Warnings>. > > Some categories are inherently unsafe to fatalise, as documented in > <https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS>.
One disadvantage of making the warnings fatal is that it immediately aborts the test. Another option would be to to turn warnings into test failures, à la https://metacpan.org/pod/Test::Warnings or https://metacpan.org/pod/Test::FailWarnings. Both those modules support all the Perl versions we do, and have no non-core dependencies, but if we don't want to add any more dependencies we can incorporate the logic into one of our own testing modules. - ilmari