On Mon, May 14, 2018 at 07:47:54AM -0400, Andrew Dunstan wrote: > > > On 05/12/2018 08:47 PM, Bruce Momjian wrote: > > On Sat, May 12, 2018 at 01:22:55PM -0700, Peter Geoghegan wrote: > >> On Fri, May 11, 2018 at 2:06 PM, Bruce Momjian <br...@momjian.us> wrote: > >>> Done and URL updated. > >> I have some feedback on "Allow NOT NULL to be added to columns without > >> requiring a table rewrite". I suggest that this be phrased as "Avoid a > >> table rewrite when ALTER TABLE ADD COLUMN sets a default value for a > >> column". Referencing the fact that Postgres was previously able to do > >> this with a NULL default doesn't seem to add anything. > > Agreed, done: > > > > Allow <command>ALTER TABLE</command> to add a non-null default > > column without a table rewrite (Andrew Dunstan, Serge Rielau) > > > > > I think "a column with a non-null default" would be a bit clearer than > "a non-null default column".
Yeah, I didn't like what I had either, so I changed it to what you suggested, though it gives us an odd "with X, without Y" pattern: Allow <command>ALTER TABLE</command> to add a column with a non-null default without a table rewrite (Andrew Dunstan, Serge Rielau) -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +