Hi, On 2023-03-06 13:29:50 +0900, Michael Paquier wrote: > On Mon, Feb 20, 2023 at 01:54:00PM +0530, Bharath Rupireddy wrote: > > I ran some tests on my dev system [1] and I don't see much difference > > between v3 and v4. So, +1 for v3 patch (+ argument order swap) from > > Andres to keep the code simple and elegant. > > This thread has stalled for a couple of weeks, so I have gone back to > it. Testing on a tmpfs I am not seeing a difference if performance > for any of the approaches discussed. At the end, as I am the one > behind the introduction of pg_pwrite_zeros(), I have applied v3 after > switches the size and offset parameters to be the same way as in v4.
Thanks. Greetings, Andres Freund