> On 7 Mar 2023, at 09:35, Damir Belyalov <[email protected]> wrote:
> I felt just logging "Error: %ld" would make people wonder the meaning of
> the %ld. Logging something like ""Error: %ld data type errors were
> found" might be clearer.
>
> Thanks. For more clearance change the message to: "Errors were found: %".
I'm not convinced that this adds enough clarity to assist the user. We also
shouldn't use "error" in a WARNING log since the user has explicitly asked to
skip rows on error, so it's not an error per se. How about something like:
ereport(WARNING,
(errmsg("%ld rows were skipped due to data type incompatibility",
cstate->ignored_errors),
errhint("Skipped rows can be inspected in the database log for
reprocessing.")));
--
Daniel Gustafsson
