PGDOCS - Replica Identity quotes Hi,
Here are some trivial quote changes to a paragraph describing REPLICA IDENTITY. These changes were previously made in another ongoing R.I. patch v28-0001 [1], but it was decided that since they are not strictly related to that patch they should done separately. ====== logical-replication.sgml Section 31.1 Publication A published table must have a “replica identity” configured in order to be able to replicate UPDATE and DELETE operations, so that appropriate rows to update or delete can be identified on the subscriber side. By default, this is the primary key, if there is one. Another unique index (with certain additional requirements) can also be set to be the replica identity. If the table does not have any suitable key, then it can be set to replica identity “full”, which means the entire row becomes the key. This, however, is very inefficient and should only be used as a fallback if no other solution is possible. If a replica identity other than “full” is set on the publisher side, a replica identity comprising the same or fewer columns must also be set on the subscriber side. See REPLICA IDENTITY for details on how to set the replica identity. If a table without a replica identity is added to a publication that replicates UPDATE or DELETE operations then subsequent UPDATE or DELETE operations will cause an error on the publisher. INSERT operations can proceed regardless of any replica identity. ~~ Suggested changes: 1. The quoted "replica identity" should not be quoted -- This is the first time this term is used on this page so I think it should be using <firstterm> SGML tag, just the same as how <firstterm>publication</firstterm> looks at the top of this section. 2. The quoted "full" should also not be quoted. Replicate identities are not specified using text string "full" - they are specified as FULL (see [2]), so IMO these instances should be changed to <literal>FULL</full> to eliminate that ambiguity. ~~~ PSA patch v1 which implements the above changes. ------ [1] https://www.postgresql.org/message-id/CAA4eK1J8R-qS97cu27sF2%3DqzjhuQNkv%2BZvgaTzFv7rs-LA4c2w%40mail.gmail.com [2] https://www.postgresql.org/docs/current/sql-altertable.html#SQL-ALTERTABLE-REPLICA-IDENTITY Kind Regards, Peter Smith. Fujitsu Australia
v1-0001-PGDOCS-replica-identity-quotes.patch
Description: Binary data