On Wed, Mar 08, 2023 at 04:01:56PM +0530, Bharath Rupireddy wrote: > I understand that performance is critical here but we need to ensure > memory is used wisely. Therefore, I'd still vote to free at least the > major contributors here, that is, pfree(raw_data);, pfree(raw_page); > and pfree(flags); right after they are done using. I'm sure pfree()s > don't hurt more than resetting memory context for every block_id.
Okay by me to have intermediate pfrees between each block scanned if you feel strongly about it. > I think we need to output block data length (blk->data_len) similar to > fpilen to save users from figuring out how to get the length of a > bytea column. This will also keep block data in sync with FPI info. length() works fine on bytea, so it can be used on the block data. fpilen is a very different matter as it would be the length of a page without a hole, or just something compressed. -- Michael
signature.asc
Description: PGP signature