On Wed, Mar 15, 2023 at 7:58 PM Daniel Gustafsson <dan...@yesql.se> wrote: > > On 15 Mar 2023, at 11:18, Etsuro Fujita <etsuro.fuj...@gmail.com> wrote: > > While working on something else, I noticed that the “if (entry->conn > > == NULL)” test after doing disconnect_pg_server() when re-establishing > > a given connection in GetConnection() is pointless, because the former > > function ensures that entry->conn is NULL. So I removed the if-test. > > Attached is a patch for that. > > LGTM, nice catch. > > > I think we could instead add an assertion, but I did not, because we already > > have it in make_new_connection(). > > Agreed, the assertion in make_new_connection is enough (and is needed there).
Great! Thanks for looking! Best regards, Etsuro Fujita
