Hi all, Nathan has reported to me offlist that maintainer-clean was not doing its job for the files generated by gen_node_support.pl in src/backend/nodes/ for the query jumbling. Attached is a patch to take care of this issue.
While on it, I have found a comment in the related README that was missing a refresh. Any objections or comments? -- Michael
diff --git a/src/backend/nodes/Makefile b/src/backend/nodes/Makefile
index af12c64878..0a95e683d0 100644
--- a/src/backend/nodes/Makefile
+++ b/src/backend/nodes/Makefile
@@ -95,7 +95,8 @@ $(top_builddir)/src/include/nodes/header-stamp: node-support-stamp
copyfuncs.o: copyfuncs.c copyfuncs.funcs.c copyfuncs.switch.c | node-support-stamp
equalfuncs.o: equalfuncs.c equalfuncs.funcs.c equalfuncs.switch.c | node-support-stamp
outfuncs.o: outfuncs.c outfuncs.funcs.c outfuncs.switch.c | node-support-stamp
+queryjumblefuncs.o: queryjumblefuncs.c queryjumblefuncs.funcs.c queryjumblefuncs.switch.c | node-support-stamp
readfuncs.o: readfuncs.c readfuncs.funcs.c readfuncs.switch.c | node-support-stamp
maintainer-clean: clean
- rm -f node-support-stamp $(addsuffix funcs.funcs.c,copy equal out read) $(addsuffix funcs.switch.c,copy equal out read) nodetags.h
+ rm -f node-support-stamp $(addsuffix funcs.funcs.c,copy equal out queryjumble read) $(addsuffix funcs.switch.c,copy equal out queryjumble read) nodetags.h
diff --git a/src/backend/nodes/README b/src/backend/nodes/README
index 7cf6e3b041..9a28b770d3 100644
--- a/src/backend/nodes/README
+++ b/src/backend/nodes/README
@@ -88,10 +88,10 @@ Suppose you want to define a node Foo:
If you intend to inherit from, say a Plan node, put Plan as the first field
of your struct definition. (The T_Foo tag is created automatically.)
2. Check that the generated support functions in copyfuncs.funcs.c,
- equalfuncs.funcs.c, outfuncs.funcs.c and readfuncs.funcs.c look
- correct. Add attributes as necessary to control the outcome. (For
- some classes of node types, you don't need all four support functions.
- Use node attributes similar to those of related node types.)
+ equalfuncs.funcs.c, outfuncs.funcs.c, queryjumblefuncs.funcs.c and
+ readfuncs.funcs.c look correct. Add attributes as necessary to control the
+ outcome. (For some classes of node types, you don't need all four support
+ functions. Use node attributes similar to those of related node types.)
3. Add cases to the functions in nodeFuncs.c as needed. There are many
other places you'll probably also need to teach about your new node
type. Best bet is to grep for references to one or two similar existing
signature.asc
Description: PGP signature
