Hi, > > ▶ 6/6 - received at least one connection on node1 OK > > ▶ 6/6 - received at least one connection on node2 OK > > ▶ 6/6 - received at least one connection on node3 OK > > ▶ 6/6 - received 50 connections across all nodes OK > > Good point. > > > Finally, I changed a few small typos in your updated commit message > > (some of which originated from my earlier commit messages) > > +1
Hi, > I would like to see this wrapped up in the current CF, what do you think about > the attached? In v15-0001: ``` + conn->addr = calloc(conn->naddr, sizeof(AddrInfo)); + if (conn->addr == NULL) + { + libpq_append_conn_error(conn, "out of memory"); + return 1; + } ``` According to the man pages, in a corner case when naddr is 0 calloc can return NULL which will not indicate an error. So I think it should be: ``` if (conn->addr == NULL && conn->naddr != 0) ``` Other than that v15 looked very good. It was checked on Linux and MacOS including running it under sanitizer. I will take a look at v16 now. -- Best regards, Aleksander Alekseev