Hi, On 2023-04-07 18:26:28 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > On 2023-04-07 17:46:33 -0400, Tom Lane wrote: > >> After quickly eyeing the diffs, I'm just going to take the new output > >> as good. I'm not surprised that there are additional output messages > >> given the additional catalog entries this made. I *am* a bit surprised > >> that some messages seem to have disappeared --- are there places where > >> this resulted in fewer catalog accesses than before? Nonetheless, > >> there's no good reason to assume this test is exposing any bugs. > > > I wonder if the issue is that the new paths miss a hook invocation. > > Perhaps. I'm content to silence the buildfarm for today; we can > investigate more closely later.
Makes sense. I think https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo&dt=2023-04-07%2021%3A16%3A04 might point out a problem with the pg_dump or pg_upgrade backward compat paths: --- C:\\prog\\bf/root/upgrade.drongo/HEAD/origin-REL9_5_STABLE.sql.fixed 2023-04-07 23:51:27.641328600 +0000 +++ C:\\prog\\bf/root/upgrade.drongo/HEAD/converted-REL9_5_STABLE-to-HEAD.sql.fixed 2023-04-07 23:51:27.672571900 +0000 @@ -416,9 +416,9 @@ -- Name: entry; Type: TABLE; Schema: public; Owner: buildfarm -- CREATE TABLE public.entry ( - accession text, - eid integer, - txid smallint + accession text NOT NULL, + eid integer NOT NULL, + txid smallint NOT NULL ); ALTER TABLE public.entry OWNER TO buildfarm; -- Looks like we're making up NOT NULL constraints when migrating from 9.5, for some reason? Greetings, Andres Freund
