Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert

[Daniel Gustafsson]

> On 14 Apr 2023, at 15:51, Tom Lane <t...@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <dan...@yesql.se> writes:
>> I mainly put save_errno back into SOCK_ERRNO for greppability, I don't have 
>> any
>> strong opinions either way so I went with the latter suggestion.  Attached v3
>> does the above change and passes the tests both with a broken and working
>> system CA pool.  Unless objections from those with failing local envs I 
>> propose
>> this is pushed to close the open item.
> 
> One more question when looking at it with fresh eyes: should the argument
> of X509_verify_cert_error_string be "ecode" or "vcode"?

Good catch, it should be vcode.

--
Daniel Gustafsson