On Thu, Apr 20, 2023 at 10:13:04AM +0900, Michael Paquier wrote: > On Wed, Apr 19, 2023 at 08:50:13PM -0400, Melanie Plageman wrote: > > I thought about changing parameter and local variable names to remove > > the prefix, but in the original discussion folks seemed to think it made > > sense to leave the "C level" references with an "io" prefix. I think we > > could change many of them, but some of them may be required for clarity. > > I agree with the feeling of not touching the internal variables. It > makes them easier to grep, and it seems that these are mostly on lines > where there is little context about what they refer to.. > > Perhaps others have comments or objections, so let's wait a bit, but > I'd be OK to apply this one myself, with a catversion bump. (Happy to > help.)
Great, thanks! Once you feel an appropriate amount of time has passed, it would be great if you could apply it. I forgot to add a note about the catalog version bump. oops! - Melanie
