On Fri, Apr 21, 2023 at 10:49:48AM +0200, Daniel Gustafsson wrote: > On 21 Apr 2023, at 01:32, Nathan Bossart <nathandboss...@gmail.com> wrote: >> I am -0.5 for this. If you are writing a new background worker, it's >> probably reasonable to expect that you can locate the definition of >> BGW_MAXLEN. > > Of course. The question is if it's a helpful addition for someone who is > reading the documentation section on implementing background workers where we > explicitly mention BGW_MAXLEN without saying what it is.
IMHO it's better to have folks use the macro so that their calls to snprintf(), etc. are updated when BGW_MAXLEN is changed. But I can't say I'm strongly opposed to adding the value to the docs if you think it is helpful. >> Also, I think there's a good chance that we'd forget to update >> such documentation the next time we adjust it. > > There is that, but once set to MAXPGPATH it seems unlikely to change > particularly often so it seems the wrong thing to optimize for. True. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
