On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand <bertranddrouvot...@gmail.com> wrote: >
Few comments: ============ 1. +$node_subscriber->init(allows_streaming => 'logical'); +$node_subscriber->append_conf('postgresql.conf', 'max_replication_slots = 4'); Why do we need slots on the subscriber? 2. +# Speed up the subscription creation +$node_primary->safe_psql('postgres', "SELECT pg_log_standby_snapshot()"); + +# Explicitly shut down psql instance gracefully - to avoid hangs +# or worse on windows +$psql_subscriber{subscriber_stdin} .= "\\q\n"; +$psql_subscriber{run}->finish; + +# Insert some rows on the primary +$node_primary->safe_psql('postgres', + qq[INSERT INTO tab_rep select generate_series(1,10);]); + +$node_primary->wait_for_replay_catchup($node_standby); + +# To speed up the wait_for_subscription_sync +$node_primary->safe_psql('postgres', "SELECT pg_log_standby_snapshot()"); +$node_subscriber->wait_for_subscription_sync($node_standby, 'tap_sub'); It is not clear to me why you need to do pg_log_standby_snapshot() twice. 3. Why do you need $psql_subscriber to be used in a different way instead of using safe_psql as is used for node_primary? -- With Regards, Amit Kapila.