Hi, On 5/4/23 6:43 AM, Amit Kapila wrote:
On Thu, May 4, 2023 at 8:37 AM vignesh C <vignes...@gmail.com> wrote:Thanks for posting the updated patch, I had run this test in a loop of 100 times to verify that there was no failure because of race conditions. The 100 times execution passed successfully. One suggestion: "wal file" should be changed to "WAL file": +# Request a checkpoint on the standby to trigger the WAL file(s) removal +$node_standby->safe_psql('postgres', 'checkpoint;'); + +# Verify that the wal file has not been retained on the standby +my $standby_walfile = $node_standby->data_dir . '/pg_wal/' . $walfile_name;Thanks for the verification. I have pushed the patch.
It looks like there is still something wrong with this test as there are a bunch of cfbot errors on this new test (mainly on macOS - Ventura - Meson). I'll try to reproduce with more debug infos. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
