On 08.05.23 17:48, Peter Eisentraut wrote:
On 27.04.23 13:44, Daniel Verite wrote:
This collation has an empty pg_collation.collversion column, instead
of being set to the same value as "und-x-icu" to track its version.

The original patch implements this as an INSERT in which it would be easy to
fix I guess, but in current HEAD it comes as an entry in
include/catalog/pg_collation.dat:

{ oid => '963',
   descr => 'sorts using the Unicode Collation Algorithm with default
settings',
   collname => 'unicode', collprovider => 'i', collencoding => '-1',
   colliculocale => 'und' },

Should it be converted back into an INSERT or better left
in this file and collversion being updated afterwards?

How about we do it with an UPDATE command.  We already do this for pg_database in a similar way.  See attached patch.

This has been committed.


Reply via email to