On 10.05.23 20:04, Andres Freund wrote:
This commit adds a test
is(scalar @lp_off, $ROWCOUNT, "acquired row offsets");
*before* that skip_all call. This appears to be invalid. If the skip_all
happens, you get a complaint like
t/004_verify_heapam.pl (Wstat: 0 Tests: 1 Failed: 0)
Parse errors: Bad plan. You planned 0 tests but ran 1.
We could move the is() test after all the skip_all's. Any thoughts?
I think the easiest fix is to just die if we can't get the offsets - it's not
like we can really continue afterwards...
This should do it:
-is(scalar @lp_off, $ROWCOUNT, "acquired row offsets");
+scalar @lp_off == $ROWCOUNT or BAIL_OUT("row offset counts mismatch");
But I'm not sure what the latest thinking on BAIL_OUT is. It is used
nearby in a similar way though.
