On Mon, 2023-05-22 at 14:34 +0200, Peter Eisentraut wrote:
> Please put blank lines between
>
> </sect3>
> <sect3 ...>
>
> etc., matching existing style.
>
> We usually don't capitalize the collation parameters like
>
> CREATE COLLATION mycollation1 (PROVIDER = icu, LOCALE = 'ja-JP);
>
> elsewhere in the documentation.
>
> Table 24.2. ICU Collation Settings should probably be sorted by key,
> or
> at least by something.
>
> All tables should referenced in the text, like "Table x.y shows this
> and
> that." (Note that a table could float to a different page in some
> output formats, so just putting it into a section without some
> introductory text isn't sound.)
Thank you, done.
> Table 24.1. ICU Collation Levels shows punctuation as level 4, which
> is
> only true in shifted mode, which isn't the default. The whole
> business
> of treating variable collation elements is getting a bit lost in this
> description. The kv option is described as "Classes of characters
> ignored during comparison at level 3.", which is effectively true but
> not the whole picture.
I organized the documentation around practical examples and available
options, and less around the conceptual model. I think that's a good
start, but you're right that it over-simplifies in a few areas.
Discussing the model would work better along with an explanation of ICU
rules, where you can make better use of those concepts. I feel like
there are some interesting things that can be done with rules, but I
haven't had a chance to really dig in yet.
Regards,
Jeff Davis
