> On 26 May 2023, at 04:08, Michael Paquier <mich...@paquier.xyz> wrote: > On Thu, May 25, 2023 at 10:16:27AM +0200, Daniel Gustafsson wrote:
>> The changes to the Windows buildsystem worry me a bit, but they don't move >> the >> goalposts in either direction wrt to LibreSSL on Windows so for the purpose >> of >> this patch we don't need to do more. Longer term we should either make >> LibreSSL work on Windows builds, or explicitly not support it on Windows. > > Yes, I was wondering what to do about that in the long term. With the > argument that the MSVC scripts may be gone over meson, it is not > really appealing to dig into that. Yeah, let's revisit this during the v17 cycle when the future of these scripts will become clearer. > Something that was missing in 0001 is the bump of OPENSSL_API_COMPAT > in meson.build. This was in 0002. > > Please find attached an updated patch only for the removal of 1.0.1. > Thanks for the review. LGTM. -- Daniel Gustafsson