The SSL tests for pg_ctl restarts with an incorrect key passphrase run pg_ctl manually and use the internal method _update_pid to set the server PID file accordingly. This is needed since $node->restart will BAIL in case the restart fails, which clearly isn't useful to anyone wanting to test restarts. This is the only use of _update_pid outside of Cluster.pm.
To avoid this, the attached adds fail_ok functionality to restart() which makes it easier to use it in tests, and aligns it with how stop() and start() works. The resulting SSL tests are also more readable IMO. -- Daniel Gustafsson
v1-0001-Avoid-using-internal-test-methods-in-SSL-tests.patch
Description: Binary data