On Tue, Jun 13, 2023 at 02:50:30PM +0900, Michael Paquier wrote:
> + Assert(strcmp("unknown", GetConfigOption("huge_pages_status", false,
> false)) != 0);
>
> Not sure that there is anything to gain with this assertion in
> CreateSharedMemoryAndSemaphores(), because this is pretty much what
> check_GUC_init() looks after?There was a second thing that bugged me here. Would it be worth adding some checks on huge_pages_status to make sure that it is never reported as unknown when the server is up and running? I am not sure what would be the best location for that because there is nothing specific to huge pages in the tests yet, but authentication/ with 005_sspi.pl and a second one would do the job? -- Michael
signature.asc
Description: PGP signature
