On 2023-Jun-21, Peter Smith wrote: > Except, please note that there are already multiple message format > strings in the HEAD code that look like "%s for subscription ...", > that are using the get_worker_name() function for the name > substitution. > > e.g. > - "%s for subscription \"%s\" will stop because the subscription was removed" > - "%s for subscription \"%s\" will stop because the subscription was disabled" > - "%s for subscription \"%s\" will restart because of a parameter change" > - "%s for subscription %u will not start because the subscription was > removed during startup" > - "%s for subscription \"%s\" will not start because the subscription > was disabled during startup" > - "%s for subscription \"%s\" has started"
That is a terrible pattern in relatively new code. Let's get rid of it entirely rather than continue to propagate it. > So, I don't think it is fair to say that these format strings are OK > for the existing HEAD code, but not OK for the patch code, when they > are both the same. Agreed. Let's remove them all. BTW this is documented: https://www.postgresql.org/docs/15/nls-programmer.html#NLS-GUIDELINES -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "I suspect most samba developers are already technically insane... Of course, since many of them are Australians, you can't tell." (L. Torvalds)
