Hi, On 2023-06-30 14:13:11 +1200, Thomas Munro wrote: > On Fri, Jun 30, 2023 at 3:39 AM Andres Freund <and...@anarazel.de> wrote: > > I am wondering if we don't want something more generic than stashing this in > > rd_amcache. Don't want to end up duplicating relevant code across the uses > > of > > rd_amcache in every AM. > > I suppose we could try to track hot pages automatically.
I think that could be useful - but as a separate facility. The benefit of stashing the root page buffer in the relcache is that it's practically free of overhead and doesn't have complications from how many other intervening accesses there are etc. I was more thinking of just making the relevant fields part of RelationData and delegating the precise use to the individual AMs. > > I do wonder if we should have an unlocked pre-check for a) the buffer being > > valid and b) BufferTagsEqual() matching. With such a pre-check the race for > > increasing the usage count of the wrong buffer is quite small, without the > > pre-check it doesn't seem that small anymore. > > Yeah, that makes sense. Done in this version. Cool. Greetings, Andres Freund
